Port #60262: Include non-enumerable keys in __importStar helper #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports TypeScript PR #60262 which updates the
__importStar
helper to include non-enumerable properties when creating namespace imports.Changes Made
The
__importStar
helper has been updated from:To:
Key Improvements
Object.getOwnPropertyNames()
to capture both enumerable and non-enumerable propertiesfor...in
loop behavior whenObject.getOwnPropertyNames
is not availableownKeys
function onceFiles Modified
internal/printer/helpers.go
- Updated theimportStarHelper
Text fieldinternal/transformers/commonjsmodule_test.go
- Updated unit test expected outputTesting
All tests pass after accepting baseline changes. Many diff files were completely eliminated, indicating perfect matches between expected and actual output for those test cases.
Fixes #2.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.